Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "cache add" command error when not specifying :latest tag #10058

Merged
merged 1 commit into from
Dec 30, 2020
Merged

fix "cache add" command error when not specifying :latest tag #10058

merged 1 commit into from
Dec 30, 2020

Conversation

lingsamuel
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @lingsamuel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 29, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 29, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lingsamuel
Copy link
Contributor Author

/remove-kind bug
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 29, 2020
@medyagh
Copy link
Member

medyagh commented Dec 29, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10058): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10058/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10058/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10058): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10058/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10058/minikube: exec format error

medyagh
medyagh requested changes Dec 29, 2020
View reviewed changes
pkg/util/utils.go Outdated Show resolved Hide resolved
@lingsamuel lingsamuel requested a review from medyagh December 30, 2020 02:52
@lingsamuel
Automatically use latest tag for command cache
b79ab3f 
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingsamuel, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2020
@medyagh medyagh changed the title Automatically use latest tag for command cache fix "cache add" command error when not specifying :latest tag Dec 30, 2020
@medyagh
Copy link
Member

medyagh commented Dec 30, 2020

/retest-this-please

@medyagh medyagh merged commit a590ab7 into kubernetes:master Dec 30, 2020
@lingsamuel lingsamuel deleted the auto-latest branch December 31, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cache add should use "latest" automatically
5 participants
@lingsamuel @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot